Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.0 cache bug #1074

Closed
atian25 opened this issue Feb 23, 2018 · 7 comments
Closed

3.1.0 cache bug #1074

atian25 opened this issue Feb 23, 2018 · 7 comments

Comments

@atian25
Copy link
Contributor

atian25 commented Feb 23, 2018

it seems that, nunjucks@3.1.0 noCache: false is break.

see https://github.com/atian25/nunjucks-cache-bug/blob/master/test/index.test.js

when change to 3.0.1 the test pass.

@maxcbc
Copy link

maxcbc commented Feb 23, 2018

Just spent 2 days fighting this. Have experienced this too.

@fdintino
Copy link
Collaborator

Sorry about that. Working on a fix at this very moment.

fdintino added a commit to theatlantic/nunjucks-bower that referenced this issue Feb 23, 2018
@fdintino
Copy link
Collaborator

Could you check if this is now fixed with the 3.1.1 release?

@atian25
Copy link
Contributor Author

atian25 commented Feb 24, 2018

yes, it fixed.

but still a security warning: https://nodesecurity.io/orgs/eggjs/projects/c0f43ecf-9b21-436c-85b9-dfa163de53e7/26

@fdintino
Copy link
Collaborator

It looks like that security warning is for the hoek library. It doesn't seem to have anything to do with nunjucks.

@popomore
Copy link
Contributor

nunjucks@3.1.2 > chokidar@1.7.0 > fsevents@1.1.3 > node-pre-gyp@0.6.39 > hawk@3.1.3 > hoek@2.16.3

But hoek is in the dependency chain of nunjucks

@atian25
Copy link
Contributor Author

atian25 commented Feb 24, 2018

chokidar@2.2.0

ttencate added a commit to alakajam-team/alakajam that referenced this issue Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants