Removed chokidar from optional dependencies #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`chokidar` is listed under dependencies and optional dependencies, but it's not optional (gets used in `node-loaders.js`). It's currently not possible to use Nunjucks with `npm --no-optional` as it will throw an `Cannot find module 'chokidar'` error.
|
Actually, I think this is a regression in 3.1.0. The require for chokidar should be inside a try/catch; I think that would be the appropriate fix. |
fdintino
added a commit
to theatlantic/nunjucks-bower
that referenced
this pull request
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chokidaris listed under dependencies and optional dependencies, but it's not optional (gets used innode-loaders.js). It's currently not possible to use Nunjucks withnpm --no-optionalas it will throw anCannot find module 'chokidar'error.