Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeResolveLoader #1197

Merged
merged 1 commit into from Mar 5, 2019
Merged

Add NodeResolveLoader #1197

merged 1 commit into from Mar 5, 2019

Conversation

fdintino
Copy link
Collaborator

@fdintino fdintino commented Mar 5, 2019

Summary

Adds NodeResolveLoader, a Loader that loads templates using node's require.resolve.

Fixes #1175

Checklist

@fdintino
Copy link
Collaborator Author

fdintino commented Mar 5, 2019

The appveyor failure seems to indicate that I'm not using cross-env correctly to test this on windows. I'll need to investigate more later.

@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #1197 into master will decrease coverage by 0.21%.
The diff coverage is 64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1197      +/-   ##
=========================================
- Coverage   89.81%   89.6%   -0.22%     
=========================================
  Files          22      22              
  Lines        2995    3020      +25     
=========================================
+ Hits         2690    2706      +16     
- Misses        305     314       +9
Impacted Files Coverage Δ
nunjucks/index.js 64.7% <ø> (ø) ⬆️
nunjucks/src/node-loaders.js 68.65% <64%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99154e...c3741c9. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1197 into master will decrease coverage by 0.21%.
The diff coverage is 64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1197      +/-   ##
=========================================
- Coverage   89.81%   89.6%   -0.22%     
=========================================
  Files          22      22              
  Lines        2995    3020      +25     
=========================================
+ Hits         2690    2706      +16     
- Misses        305     314       +9
Impacted Files Coverage Δ
nunjucks/index.js 64.7% <ø> (ø) ⬆️
nunjucks/src/node-loaders.js 68.65% <64%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99154e...c3741c9. Read the comment docs.

@fdintino fdintino merged commit f997a52 into master Mar 5, 2019
@fdintino fdintino deleted the pr-noderesolveloader branch March 5, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Resolver for NPM Modules
2 participants