Use strict #386
Merged
Use strict #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2015
Merged
|
I merged #385 but for some reason this PR isn't updating to show that master already has the single quote commit... Do you know what it hasn't updated? I can't do the code review until I see the single commit for this. |
|
I don't know why, I try to rebase for it. |
| var expect, util, lib; | ||
| 'use strict'; | ||
|
|
||
| var expect, util, lib, Environment, Loader, templatesPath; |
There was a problem hiding this comment.
Should define a variable before use it in strict mode.
|
It can be reviewed now. |
|
Thanks. All tests are passing, so that's good. Let's hope it doesn't break anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split PR from #383
Based on #385, merge this PR after that.