Fix error when template is not found #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I know there are other windows users that use nunjucks. Maybe something recent broke it. I'll take a look at Appveyor, thanks. |
jlongster
added a commit
that referenced
this pull request
Mar 10, 2015
Fix error when template is not found
|
@jlongster it looks like the problem come from my PRs for relative paths, so it's probably my fault. I'm looking at it, but it will be great if you can setup a project on Appveyor associated with nunjucks so that in the future it avoids breaking Windows compatibility. |
|
I think the problem is coming from here: https://github.com/mozilla/nunjucks/blob/master/src/compiler.js#L127 Basically windows path with I'm working on a fix and will propose a PR in the coming hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for an error I introduced in my precedent PR (Sorry ...).
I'm currently running some tests for GitBook on Windows and Nunjucks is not working there (tests are all failing).
You should maybe consider using Appveyor (as simple as travis and free for open source projects) to test Nunjucks on Windows.
I'll take a deep look at why Nunjucks is not working (it's reason why GitBook is not working).