fix watching in node-loader #390
Conversation
| @@ -31,6 +31,7 @@ var FileSystemLoader = Loader.extend({ | |||
| var watcher = chokidar.watch(p, { ignoreInitial: true }); | |||
|
|
|||
| watcher.on('all', function(event, fullname) { | |||
| fullname = path.join(process.cwd(), fullname); | |||
There was a problem hiding this comment.
Why not path.resolve ? It's using resolve in getSource
There was a problem hiding this comment.
That works, I forgot about that.
There was a problem hiding this comment.
Why not path.resolve(p, fullname) ?
|
I'm using the watcher but also the noCache option that's maybe why I didn't see this bug. |
|
Yeah, |
| @@ -31,6 +31,7 @@ var FileSystemLoader = Loader.extend({ | |||
| var watcher = chokidar.watch(p, { ignoreInitial: true }); | |||
|
|
|||
| watcher.on('all', function(event, fullname) { | |||
| fullname = path.resolve(fullname); | |||
There was a problem hiding this comment.
Is fullname (from chokidar events) relative to p or absolute ?
Because if the path is relative, this will work only if p == process.cwd() which is not always the case.
There was a problem hiding this comment.
fullname is the path that changed according to the path you gave chokidar, p in this case. If p is absolute, fullname will be absolute (I think). If it's relative, it will be relative. If p is views, fullname will be views/index.html.
So basically this should work because chokidar's watch patch is relative to process.cwd(). If it isn't, you gave it an absolute path.
@SamyPesse The relative templates broke watching. In
getSourcethefullpathkey inpathsToNamesis now always fully absolute, but in the watcher the path it gets is still just a relative path. I think this fixes it, but can you verify?Are you not using the watcher?