Adds set block assignments a la jinja2 #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one more test for set block assignments
| @@ -1,4 +1,4 @@ | |||
| /*! Browser bundle of nunjucks 2.3.0 (slim, only works with precompiled templates) */ | |||
| /*! Browser bundle of nunjucks 3.0.0-dev.1 (slim, only works with precompiled templates) */ | |||
There was a problem hiding this comment.
Please revert the changes to the browserfiles; that's done only at release time, otherwise it causes too many conflicts.
|
Very nicely done, thanks so much for the PR! A couple minor comments above, ping me when they're addressed and I'll press the button! |
|
Ok, that should do it! |
carljm
added a commit
that referenced
this pull request
Feb 2, 2016
Adds set block assignments a la jinja2
carljm
added a commit
that referenced
this pull request
Feb 2, 2016
Adds set block assignments a la jinja2
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented set block assignments as requested in #582.
I've updated the docs accordingly, taking inspiration by the jinja documentation.