Add support for boolean globals #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only throw an error when a global is "undefined" when calling getGlobal function in environment.
carljm
added a commit
that referenced
this pull request
Mar 10, 2016
Add support for boolean globals
carljm
added a commit
that referenced
this pull request
Mar 10, 2016
Add support for boolean globals
carljm
added a commit
that referenced
this pull request
Mar 10, 2016
* 2.x: (43 commits) Bump versions for dev. Update maintenance docs. Revert accidental changes to mocha.js. Bump version to 2.4.0. Update changelog. Merge pull request #694 from mariusbuescher/master Add note about include and blocks; update wrapping of templating docs. Merge pull request #688 from pra85/patch-1 Rename all test templates to use .j2 extension. Update changelog. Revert "make include statements trigger async conversion inside if/for statements (fixes #372)" Merge pull request #672 from TrySound/yargs Update changelog. Split backported and non-backported portions of #667 in changelog. More acks in changelog. Merge pull request #668 from oyyd/cn-doc Don't allow included templates to write to the including scope. Update changelog for opts.dev fix. Split include tests. Fix references to env dev opt. ...
carljm
added a commit
that referenced
this pull request
Mar 14, 2016
* master: (88 commits) Bump versions for dev. Update maintenance docs. Revert accidental changes to mocha.js. Bump version to 2.4.0. Update changelog. Merge pull request #694 from mariusbuescher/master Update changelog. Add support for boolean globals Add note about include and blocks; update wrapping of templating docs. Merge pull request #688 from pra85/patch-1 Add note about include and blocks; update wrapping of templating docs. Update api.md fixed bad character leading % in {% endraw %} Respect null/none as a value in its own right, distinct from undefined. Fixes #478. Use dot reporter for npm test. Don't bail on first failed test in 'npm test'. Add acknowledgement for #561 to changelog. Tighter scoping of vars in blocks, to match Jinja2. Fixes #561. Rename all test templates to use .j2 extension. Rename all test templates to use .j2 extension. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
getGlobalfunction it throws an error when the global you want to get is falsey. It should only throw an error when the global is undefined sou you can use real boolean globals in a function (e.g. a filter).