Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #709: filters inside import tags #710

Merged
merged 4 commits into from
Apr 19, 2016
Merged

Conversation

legutierr
Copy link

Fix for #709.

@legutierr
Copy link
Author

Hi @carljm , any thoughts on this pull request?

@carljm
Copy link
Contributor

carljm commented Apr 13, 2016

Not yet, still digging out from vacation backlog :-) Nunjucks catch-up is on the todo list.

@carljm
Copy link
Contributor

carljm commented Apr 15, 2016

LGTM! Would you mind adding a changelog entry, per the existing style? Once that's done I'll merge. Thanks!

@legutierr
Copy link
Author

Hi @carljm , I think this is ready to go :)

@carljm carljm merged commit 4c1d2bd into mozilla:master Apr 19, 2016
@carljm
Copy link
Contributor

carljm commented Apr 19, 2016

Thanks, merged!

carljm added a commit that referenced this pull request Apr 19, 2016
fixes issue #709: filters inside import tags
@legutierr
Copy link
Author

Thank you, @carljm !

carljm pushed a commit that referenced this pull request May 26, 2016
It should have been #746 instead of #710
carljm pushed a commit that referenced this pull request May 27, 2016
It should have been #746 instead of #710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants