Add favicon to HTML template #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are going to add a favicon, don't forget Safari pinned tabs icon. You will need an SVG icon to do it. If you want to support all formats it is really quite complicated these days. The real favicon generator does a good job of helping you in this regard. |
|
@vipickering Any harm in starting simple with what's here and iterating on it? |
carljm
pushed a commit
that referenced
this pull request
Aug 18, 2016
|
@carljm no, not really. Start simple always best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add favicon so browser will show it in tab page like this:
This icon was created by builtbylane, and converted to PNG format.
Related issue: #550