Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verbatim as alias of raw for parity w/ Twig #874

Merged
merged 4 commits into from
Oct 18, 2016

Conversation

jbmoelker
Copy link
Collaborator

Summary

Proposed change:

  • Add verbatim as an alias of raw for compatibility with Twig (see Twig verbatim tag).
  • Extends parseRaw with tagName parameter to support verbatim.
  • Reuses raw tag tests.
  • Explains compatibility in docs.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

(Tick of items by replacing [ ] by [x])

// Look for upcoming raw blocks (ignore all other kinds of blocks)
var rawBlockRegex = /([\s\S]*?){%\s*(raw|endraw)\s*(?=%})%}/;
//var rawBlockRegex = /([\s\S]*?){%\s*(raw|endraw)\s*(?=%})%}/;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this and this PR is ready to be merged

@ricordisamoa
Copy link
Contributor

There should be one-- and preferably only one --obvious way to do it.

The Zen of Python

@jbmoelker
Copy link
Collaborator Author

@vecmezoni I removed forgotten comment and resolved merge conflicts.

@vecmezoni vecmezoni merged commit adb853d into mozilla:master Oct 18, 2016
@vecmezoni
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants