Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Add prompt when an updated service worker is found. #11

Merged
merged 1 commit into from
Sep 25, 2015

Conversation

brendandahl
Copy link
Contributor

Simple version before we start adding a "pretty" UI.

@marco-c
Copy link
Contributor

marco-c commented Sep 24, 2015

Instead of actually doing something, we could call a user-defined function to let them do what they want (I guess, depending on the use case, a developer could want to force the update or ignore it, instead of prompting the user).

@mykmelez
Copy link
Contributor

Argh, GitHub didn't make me watch this repository after I moved it from my personal account to the @mozilla organization, so I only just now saw this pull request.

Instead of actually doing something, we could call a user-defined function to let them do what they want (I guess, depending on the use case, a developer could want to force the update or ignore it, instead of prompting the user).

I like that idea. Then the Oghliner app could implement that user-defined function as a demo of how to do it, and a developer could reuse Oghliner's implementation or create their own.

But this is a good start, so I'm going to merge this, and then we can make that change in a followup.

mykmelez added a commit that referenced this pull request Sep 25, 2015
Add prompt when an updated service worker is found.
@mykmelez mykmelez merged commit 924cbe4 into mozilla:master Sep 25, 2015
@marco-c
Copy link
Contributor

marco-c commented Sep 25, 2015

But this is a good start, so I'm going to merge this, and then we can make that change in a followup.

I was going to file a follow-up issue, but I think #5 serves the purpose.

@brendandahl
Copy link
Contributor Author

Instead of actually doing something, we could call a user-defined function to let them do what they want (I guess, depending on the use case, a developer could want to force the update or ignore it, instead of prompting the user)

I had considered this, but I'm not sure of the value of it as it seems we'd just be re-implementing these events and the user could just listen to the events themselves and implement whatever they want. I think it would be good to have better UI for this when we make things "pretty."

@marco-c
Copy link
Contributor

marco-c commented Sep 29, 2015

I had considered this, but I'm not sure of the value of it as it seems we'd just be re-implementing these events and the user could just listen to the events themselves and implement whatever they want.

That's true, the only value would be to hide the service workers API from users and provide a simpler API.

I think it would be good to have better UI for this when we make things "pretty."

I'm not sure we should implement any UI in oghliner, in particular when using it as a tool. I'd expect it to simply allow me, as an app developer, to simplify adding offline support and deploying to GitHub pages, but I wouldn't want it to provide a different UI than what I want for my app.

@mykmelez
Copy link
Contributor

I'm not sure we should implement any UI in oghliner, in particular when using it as a tool. I'd expect it to simply allow me, as an app developer, to simplify adding offline support and deploying to GitHub pages, but I wouldn't want it to provide a different UI than what I want for my app.

Agreed, when using it as a tool: then it should simplify offlining and deploying to GitHub Pages without modifying your app's look and feel. But when using it as a template, it's useful for it to provide an update flow that you can use as-is, repurpose, or remove.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants