Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Use gutil.log to log messages; log errors/warnings in red #131

Merged
merged 4 commits into from
Nov 4, 2015

Conversation

marco-c
Copy link
Contributor

@marco-c marco-c commented Nov 3, 2015

No description provided.

@mykmelez
Copy link
Contributor

mykmelez commented Nov 4, 2015

I don't see any warnings being logged here, but shouldn't we log those in a different color?

Also, I'm not sure this quite fixes #26. It's certainly part of the solution, but #26 is a bit broader (and, ok, also a bit vaguer).

@marco-c
Copy link
Contributor Author

marco-c commented Nov 4, 2015

We're currently logging both errors and warnings in red. What color could we use for warnings?

@mykmelez
Copy link
Contributor

mykmelez commented Nov 4, 2015

The most conventional pattern I've seen is to color warning messages yellow. See for example http://isabelcastillo.com/error-info-messages-css and http://www.jankoatwarpspeed.com/css-message-boxes-for-different-message-types/.

mykmelez added a commit that referenced this pull request Nov 4, 2015
Use gutil.log to log messages; log errors/warnings in red
@mykmelez mykmelez merged commit 5d62f71 into mozilla:master Nov 4, 2015
@marco-c marco-c deleted the formatting branch November 5, 2015 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants