Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wording for unlisted add-ons in the devhub (bug 1159715) #538

Merged

Conversation

magopian
Copy link
Contributor

Fixes bug 1159715

I changed some of the wordings where necessary, and just added "It is only relevant for listed add-ons." on most of the tooltips for items that are not used for unlisted add-ons.

Example of changed wording:
screen shot 2015-04-30 at 10 47 25

Example of addition of "only relevant...":
screen shot 2015-04-30 at 10 49 25

I also added an error to the payments page:
screen shot 2015-04-30 at 11 12 32

<p class="error">
{% trans %}
Contributions are only available for fully reviewed add-ons.
Contributions are only available for listed add-ons.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't seem like it should have the error class since it doesn't really seem error-ish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the same level of "errorness" as the same message saying it's only available for fully reviewed add-ons, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yeah, works for me.

@robhudson
Copy link
Member

That's a lot of l10n string changes, but r+wc.

magopian added a commit that referenced this pull request Apr 30, 2015
…sted-addons

Fix the wording for unlisted add-ons in the devhub (bug 1159715)
@magopian magopian merged commit 228c38a into mozilla:master Apr 30, 2015
@magopian magopian deleted the 1159715-fix-wording-devhub-unlisted-addons branch April 30, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants