Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rabbitmq/celery with docker #677

Merged
merged 1 commit into from Aug 26, 2015

Conversation

mstriemer
Copy link
Contributor

No description provided.

@kmaglione
Copy link
Contributor

+1 I've thought about doing this several times. This is really nicely done.

- BROKER_URL=amqp://olympia:olympia@rabbitmq/olympia

worker:
build: .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be cleaner to use extends here. Or define this as the base, and have web extend it, since that adds exposed ports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try that I had no idea that was a thing. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extends doesn't work with services that have links. So using extends means that we build some generic olympia service that does nothing before building the other two and does not seem to give any benefit. The three builds (olympia, worker and web) all take about the same length of time.

@kmaglione
Copy link
Contributor

We should probably change CELERY_ALWAYS_EAGER to False for this config. The question is, do we want to change that in settings.py, or do we want a separate set of default settings for Docker users, to be kind to new devs starting without it?

In any case, this is awesome. r+wc

@mstriemer
Copy link
Contributor Author

I'm not going to mess with the settings for now but we could definitely make this on by default in the future. I'm just modifying my local settings to test using celery.

mstriemer added a commit that referenced this pull request Aug 26, 2015
Support rabbitmq/celery with docker
@mstriemer mstriemer merged commit 10d9001 into mozilla:master Aug 26, 2015
@mstriemer mstriemer deleted the celery-docker branch August 26, 2015 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants