Do a proper _pre_setup and _post_teardown for all the tests (bug 1056870) #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magopian
force-pushed
the
1056870-pre_setup-post_teardown-all-the-things
branch
2 times, most recently
from
be24c06
to
787c399
Compare
| locale=locale).localized_string, | ||
| localized_string) | ||
| translation = Translation.objects.get(id=trans.id, locale=locale) | ||
| assert translation.localized_string == localized_string |
|
Oh, that's much nicer. Looks like there are a few tests that rely on importing the functions you moved, though. And a few ES tests that break nice Pytest reporting by doing Looks like r+wc |
|
(Maybe just split the failing test in two, mark the last part |
magopian
force-pushed
the
1056870-pre_setup-post_teardown-all-the-things
branch
from
787c399
to
98602f6
Compare
|
All fixed ;) |
magopian
added a commit
that referenced
this pull request
Aug 27, 2015
…-all-the-things Do a proper _pre_setup and _post_teardown for all the tests (bug 1056870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 1056870