Resign wrongly signed files (bug 1225036) #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magopian
force-pushed
the
1225036-resign-wrongly-signed-files
branch
5 times, most recently
from
62c3893
to
111f9b5
Compare
|
This PR is linked to #941: if it's merged first, then rebase it on this one, or the other way round, and apply the changes to |
Merged
3 tasks
| signed versions and distribute them to your users. | ||
|
|
||
| If you have any questions or comments on this, please reply to this email or | ||
| join #amo-editors on irc.mozilla.org. |
There was a problem hiding this comment.
good catch, thanks!
|
We did talk about tests and that they're mostly in #941 but I kind of felt better if we had tests for this here as well. If they're very similar I'm happy to accept code duplication compared to not having a test. Besides that, r+wc |
magopian
force-pushed
the
1225036-resign-wrongly-signed-files
branch
3 times, most recently
from
6987884
to
a2adbf3
Compare
magopian
force-pushed
the
1225036-resign-wrongly-signed-files
branch
from
a2adbf3
to
9092ffa
Compare
magopian
added a commit
that referenced
this pull request
Nov 27, 2015
…iles Resign wrongly signed files (bug 1225036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 1225036