Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Initial Setup #111

Closed
wants to merge 1 commit into from
Closed

Initial Setup #111

wants to merge 1 commit into from

Conversation

bitgeeky
Copy link
Contributor

@bitgeeky bitgeeky commented May 6, 2014


Detailed instructions for getting set up and running our Selenium tests can be found on the QMO website at https://quality.mozilla.org/docs/webqa/running-webqa-automated-tests/.

Please follow the steps in that document and feel free to ask questions in irc if you get stuck.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/irc/IRC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :-)

@@ -131,7 +131,7 @@ Functional Tests
-----------------
Functional (Selenium) tests for oneanddone are maintained by the Web QA team and can be found at [oneanddone-tests].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these will no longer be in a separate repo, it might make more sense to just indicate in which folder they can be found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably I couldn't find some better words so I carried on with this ,
Thanks for pointing out , Will change in next commit !

@bobsilverberg
Copy link
Contributor

I'm not sure whether the tests should be in /oneanddone/functional_tests or just /functional_tests. I think /oneanddone signifies the container for the django project and therefore maybe the tests should reside outside of it.

Do you have an opinion @Osmose?

@Osmose
Copy link
Contributor

Osmose commented May 8, 2014

I'm not sure whether the tests should be in /oneanddone/functional_tests or just /functional_tests. I think /oneanddone signifies the container for the django project and therefore maybe the tests should reside outside of it.

Do you have an opinion @Osmose?

Stuff under /oneanddone is generally expected to be a Django app (with the notable exception of settings, but it also doesn't have to be. Tests are also usually organized per-app.

I'd say leave it outside.

@bitgeeky
Copy link
Contributor Author

bitgeeky commented May 9, 2014

We noted some limitations of keeping the Functional Tests within the application repository. Finally, we decided continue with repository https://github.com/mozilla/oneanddone-tests Hence, this pull must be closed.

@bitgeeky bitgeeky closed this May 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants