This repository has been archived by the owner. It is now read-only.

Initial Setup #111

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@bitgeeky
Copy link
Member

bitgeeky commented May 6, 2014


Detailed instructions for getting set up and running our Selenium tests can be found on the QMO website at https://quality.mozilla.org/docs/webqa/running-webqa-automated-tests/.

Please follow the steps in that document and feel free to ask questions in irc if you get stuck.

This comment has been minimized.

@stephendonner

stephendonner May 6, 2014

Collaborator

s/irc/IRC

This comment has been minimized.

@bitgeeky

bitgeeky May 6, 2014

Member

Fixed :-)

# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

# File contains users data.

This comment has been minimized.

@stephendonner

stephendonner May 6, 2014

Collaborator

Should this be "users'"?

This comment has been minimized.

@stephendonner

stephendonner May 6, 2014

Collaborator

Or "user" or "user's"? :-)

This comment has been minimized.

@bitgeeky

bitgeeky May 6, 2014

Member

using "user"

@@ -131,7 +131,7 @@ Functional Tests
-----------------
Functional (Selenium) tests for oneanddone are maintained by the Web QA team and can be found at [oneanddone-tests].

This comment has been minimized.

@bobsilverberg

bobsilverberg May 7, 2014

Collaborator

Because these will no longer be in a separate repo, it might make more sense to just indicate in which folder they can be found.

This comment has been minimized.

@bitgeeky

bitgeeky May 7, 2014

Member

Probably I couldn't find some better words so I carried on with this ,
Thanks for pointing out , Will change in next commit !

Getting involved as a contributor
------------------------------------------

We love working with contributors to fill out the Selenium test coverage for oneanddone-tests, but it does require a few skills. You will need to know some Python, some Selenium and you will need some basic familiarity with Github.

This comment has been minimized.

@bobsilverberg

bobsilverberg May 7, 2014

Collaborator

We should probably remove references to oneanddone-tests as that sounds like the name of a separate repo. In this case I think it can just be replaced with One and Done.

This comment has been minimized.

@bitgeeky

bitgeeky May 7, 2014

Member

Will change in next commit !

#
# Example:
# credentials = mozwebqa.credentials['default']
# credentials['username']

This comment has been minimized.

@bobsilverberg

bobsilverberg May 7, 2014

Collaborator

Although this may be what the template looks like, I don't really see a lot of value in including all of these comments and examples when we might not use them. Let's just include the data that we actually need for now, and any necessary comments about that data.

For now we probably don't need anything. I think until we are ready to start testing admin features we probably don't need any credentials at all, as we'll just be using personatestuser to create a fake user for each test.

This comment has been minimized.

@bitgeeky

bitgeeky May 7, 2014

Member

Yeah you are correct, but I thought to go with a typical Web QA project Setup so I put that file in,
We don't need it for now, So I will remove it in next commit.

@@ -0,0 +1,3 @@
[DEFAULT]
api = webdriver
baseurl = http://localhost:8000

This comment has been minimized.

@bobsilverberg

bobsilverberg May 7, 2014

Collaborator

This should be https://oneanddone.paas.allizom.org as that will be the default that is used by contributors.

This comment has been minimized.

@bitgeeky

bitgeeky May 7, 2014

Member

What I was planing for for this project was that user should be able to run tests locally, that was also one of the reasons to keep the tests with application code itself.
What do you think @bobsilverberg ?

@bobsilverberg

This comment has been minimized.

Copy link
Collaborator

bobsilverberg commented May 7, 2014

I'm not sure whether the tests should be in /oneanddone/functional_tests or just /functional_tests. I think /oneanddone signifies the container for the django project and therefore maybe the tests should reside outside of it.

Do you have an opinion @Osmose?

@Osmose

This comment has been minimized.

Copy link
Member

Osmose commented May 8, 2014

I'm not sure whether the tests should be in /oneanddone/functional_tests or just /functional_tests. I think /oneanddone signifies the container for the django project and therefore maybe the tests should reside outside of it.

Do you have an opinion @Osmose?

Stuff under /oneanddone is generally expected to be a Django app (with the notable exception of settings, but it also doesn't have to be. Tests are also usually organized per-app.

I'd say leave it outside.

@bitgeeky

This comment has been minimized.

Copy link
Member

bitgeeky commented May 9, 2014

We noted some limitations of keeping the Functional Tests within the application repository. Finally, we decided continue with repository https://github.com/mozilla/oneanddone-tests Hence, this pull must be closed.

@bitgeeky bitgeeky closed this May 9, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.