Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Bug 1006569 - [privacy] Add checkbox at sign-up #130

Closed
wants to merge 1 commit into from

Conversation

bitgeeky
Copy link
Contributor

Added checkbox for privacy agreement.
This would force the new and existing users to sign privacy agreement before they can continue with the tasks.

@bitgeeky
Copy link
Contributor Author

@bobsilverberg r ?

@@ -48,3 +48,4 @@ def user_attempts_in_progress(self):
class UserProfile(models.Model):
user = models.OneToOneField(User, related_name='profile')
name = models.CharField(_lazy(u'Name'), max_length=255)
privacy_agreement = models.BooleanField(default=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call this privacy_policy_accepted

@bobsilverberg
Copy link
Contributor

A few issues:

  1. This does not work as expected. If an existing user has not accepted the privacy policy they seem to be just redirected to the home screen when trying to access a non-public area of the site, but they should be forced to accept the privacy policy in order to continue in any way.
  2. One of the existing unit tests is failing, so that should be fixed.
  3. Unit test(s) for the new feature should be created and included with the pull request.
  4. This does not address the bug in question. It only addresses a small part of it, and even that it does not address according to the requirements as specified in the bug.

@bitgeeky
Copy link
Contributor Author

Made a new Pull Request #135

@bitgeeky bitgeeky closed this Jun 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants