Bug 1031196 - Improve Display for Profile Details Page

[bitgeeky]

This version of Profile Details page looks better.

[bitgeeky]

@bobsilverberg r ?

[bobsilverberg]

As in the other PR, relying on the url is not a good idea. If you are wondering why, there is no guarantee that certain templates will always be accessed by the same urls. We may have other use cases which make templates available via different urls, so we should use data that we can control, such as the view context. Please change this to be not dependent on a url.

[bobsilverberg]

I agree that this is better than what we have currently. Please address the comments above. Also, I notice that this manifests the same bug described at [1], so let's take this opportunity to fix that as well. To see the bug in action, just go to /profile/ and then resize your browser window to make it narrow. You'll see how a block extends past the right-hand side of the container. Please try to fix that bug as part of this PR, as it's the same view.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1030786

[bitgeeky]

@bobsilverberg I made the suggested changes. I made this pull because I wanted it to look good when people see. The css bug you mention is for the whole website not just this one. Lets please deal with that css bugs separately. Please !!

[bobsilverberg]

Looks good, @bitgeeky. Thanks for doing this. We can merge this as an individual fix (after you squash the commits), but the bug still needs to be addressed, and that's actually a higher priority than this cosmetic change, which is why I asked that it be done. So please work on that now that this has been addressed.

[bitgeeky]

Thanks @bobsilverberg :-) I squashed the commits. Its ready for merge.

[bobsilverberg]

Thanks @bitgeeky. Merging.