Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Bug 1031518 - Suggest adding text to search box or tooltip #214

Closed
wants to merge 6 commits into from

Conversation

jicksy
Copy link
Contributor

@jicksy jicksy commented Nov 10, 2014

@bobsilverberg
Copy link
Contributor

Thanks for taking this on, @jicksy. I think that a better approach might be to use the help_text attribute of the form field. Take a look at the way the help text for keywords is implemented here [1] and here [2].

[1] https://github.com/mozilla/oneanddone/blob/master/oneanddone/tasks/forms.py#L50
[2] https://github.com/mozilla/oneanddone/blob/master/oneanddone/tasks/templates/tasks/form.html#L54

@@ -8,6 +8,8 @@
<p>
{{ filter.form['search'].label_tag() }}
{{ filter.form['search'] }}
</br>
{{_('Filter on task name, description, or keywords')}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space missing between {{ and _(, and also a period missing at the end of the sentence.

@bobsilverberg
Copy link
Contributor

@jicksy This pull request seems to be abandoned. Please let me know if you plan to continue working on it. If I don't hear back from you I will close the pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants