This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Bug 1050417 - Remove One and Done User REST API #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akatsoulas For a number of reasons we have decided to remove the Users API, but we're going to keep the Task API for now. r? |
| from braces.views import LoginRequiredMixin | ||
| import django_browserid.views | ||
| from tower import ugettext as _ | ||
| from random import randint | ||
| import re |
There was a problem hiding this comment.
Personally, I prefer all the import statements before from.
|
Apart from the minor comment, everything looks good here. r+ 🚀 |
|
Thanks for the review @akatsoulas! |
bobsilverberg
added a commit
that referenced
this pull request
Oct 20, 2015
Bug 1050417 - Remove One and Done User REST API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.