Add functional tests and run them via Travis #307
Conversation
bobsilverberg
force-pushed
the
functional_tests
branch
3 times, most recently
from
eba7800
to
82a14e6
Compare
| paths: | ||
| - results | ||
| permissions: public-read | ||
| bucket: fireplace-tests |
There was a problem hiding this comment.
Did you mean to leave this in? While artifacts may be useful I think we should have a more appropriate bucket name.
There was a problem hiding this comment.
Good catch. I need to set up a new bucket for these tests. Also, the secure variables in here will only work for my fork right now, so I should update those to work for the upstream repo.
|
Looks great, I added a few comments, and can't really provide much input for the app changes. |
See mozilla#307 for details
|
Thanks for the review, @davehunt. I have addressed your comments in a new commit. |
|
Test related code looks good. I haven't run any tests locally (would you like me to?) This is an r+ from me, but would be good to get someone familiar with Django or pytest-django to look over the changes too. |
bobsilverberg
force-pushed
the
functional_tests
branch
from
9277d2b
to
8595cec
Compare
|
@akatsoulas or @glogiotatidis r? please and thank you |
| @@ -1,4 +1,9 @@ | |||
| [flake8] | |||
| ignore=E121,E123,E124,E125,E126,E129 | |||
| max-line-length=150 | |||
|
Great work @bobsilverberg! r+ 💯 |
|
I like pushing green buttons which are backed by r+ code :-) |
Add functional tests and run them via Travis
This adds some functional tests to the oneanddone repo and allows them to be run by Travis. There is definitely room for improvement here, but I wanted to try to get this initial version landed and then iterate on improvements.