This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Remove allow_multiple_finishes from Task models #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2013
Closed
|
Just a tip, if you put "Fix #5" in a commit message it will auto-resolve issue #5. |
| @@ -48,28 +47,12 @@ class Task(CreatedModifiedModel): | |||
| def is_available(self): | |||
| """Whether this task is available for users to attempt.""" | |||
| now = timezone.now() | |||
| if self.end_date and now > self.end_date: | |||
| if ( | |||
There was a problem hiding this comment.
This could even just be:
@property
def is_available(self):
"""Whether this task is available for users to attempt."""
return not (self.end_date and now > self.end_date or
self.start_date and now < self.start_date)
|
Only thing this is missing is a migration for the database. We're using South for migrations, so running this should be all you need: ./manage.py schemamigration --auto tasks
./manage.py migrate |
|
Oh, I created a migration, but I guess I neglected to add it to the commit. I will fix tomorrow. |
Fix start_date bug in AvailableTasksView.get_queryset Add migration Make is_available property more concise
|
@Osmose I added the migration and fixed up the property as per your suggestion. r? |
|
r+ 📼 Merged in b85a1da. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24