This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
Add search for badges, programs to the API #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing...future iterations could include tags (although we're not tagging much right now in CSOL, we could...) and description. |
|
|
||
| * `issuer` - issuer shortname | ||
| * `tags` - list of tags the entry must have all of\*\* | ||
| * **search**: Filter out programs whose name isn't like the given string. "Likeness" is determined by generating a case-insensitive, unbounded regexp (i.e., `new Regexp(searchTerm, 'i')`). |
There was a problem hiding this comment.
is this a typo? "Filter out programs whose name isn't like the given string" do you mean is like the given string?
There was a problem hiding this comment.
does this also mean that if wanted to get clever we could pass in regexes?
There was a problem hiding this comment.
Not a typo, though I guess it could be clearer: We are filtering out programs that don't match.
And yeah, that does mean you can get clever and pass in regexps (as long as you don't wrap it with / and /)
|
I vote for immediate merge and deploy to staging. |
brianloveswords
added a commit
that referenced
this pull request
Jun 18, 2013
Add search for badges, programs to the API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236.
This adds recognition for the
searchquery parameter to/v2/badgesand/v2/programs.Currently the search is only effective against the
nameproperty. I can adjust that if necessary.Note, we still don't have categorical filtering on
/v2/badges– currently the only way to filter is with search terms. I'm not sure if the frontend of CSOL requires categorical filtering (like we have for programs – things like age range, type of activity, categories, etc.); if so, we should open another ticket for it.@cmcavoy to review.