Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

A patch to parameterize the dashboard location #163

Merged
merged 1 commit into from Feb 17, 2012

Conversation

dclarke
Copy link
Contributor

@dclarke dclarke commented Feb 17, 2012

STATIC_ARGS environment variable now used to pass in arbitrary json object to the extension.

this patch has all the fixes.

STATIC_ARGS environment variable now used to pass in arbitrary json object to the extension
dclarke added a commit that referenced this pull request Feb 17, 2012
A patch to parameterize the dashboard location
@dclarke dclarke merged commit 1c0690b into mozilla:develop Feb 17, 2012
@dclarke
Copy link
Contributor Author

dclarke commented Feb 17, 2012

Is it possible to inline $(DASHBOARD) like so:
cfx_args += --static-args="{ "dashboard": "$(DASHBOARD)" }"
anantn commented on e12a5fd addons/jetpack/lib/main.js:L62
a day ago

Where is tmp.dashboard coming from? I'd prefer if we used just one global instead of two, it is possible to define only DASHBOARD_HOST and change the following code to use only that.

fixed all of these issues / committed. believe things look standard now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant