Merge pull request #61 from pdehaan/issue-48-redux

Convert keywords to an array
mozilla · Sep 2, 2016 · 61c58cb · 61c58cb
2 parents cef465e + 89f76fc
commit 61c58cb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/parser.js b/parser.js
@@ -36,7 +36,10 @@ function buildRuleset(name, rules, processors) {
       }
 
       if (value) {
-        return value.trim();
+        if (value.trim) {
+          return value.trim();
+        }
+        return value;
       }
     }
   };
@@ -82,6 +85,9 @@ const metadataRules = {
     rules: [
       ['meta[name="keywords"]', node => node.element.getAttribute('content')],
     ],
+    processors: [
+      (keywords) => keywords.split(',').map((keyword) => keyword.trim()),
+    ]
   },
 
   title: {

diff --git a/tests/metadataRules.test.js b/tests/metadataRules.test.js
@@ -21,7 +21,7 @@ function ruleTest(testName, testRule, expected, testTag) {
     const found = rule(doc, {
       url: 'http://www.example.com/'
     });
-    assert.equal(found, expected, `Unable to find ${testName} in ${html}`);
+    assert.deepEqual(found, expected, `Unable to find ${testName} in ${html}`);
   });
 }
 
@@ -112,10 +112,10 @@ describe('Type Rule Tests', function() {
 
 
 describe('Keywords Rule Tests', function() {
-  const keywords = 'Cats, Kitties, Meow';
+  const keywords = ['Cats', 'Kitties', 'Meow'];
 
   const ruleTests = [
-    ['keywords', `<meta name="keywords" content="${keywords}" />`],
+    ['keywords', `<meta name="keywords" content="${keywords.join(', ')}" />`],
   ];
 
   ruleTests.map(([testName, testTag]) => ruleTest(testName, metadataRules.keywords, keywords, testTag));