Return keywords as array instead of string

mozilla · Aug 23, 2016 · b88045b · b88045b
1 parent 7e8b27f
commit b88045b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/parser.js b/parser.js
@@ -18,12 +18,20 @@ function buildRuleset(name, rules) {
     if (maxNode) {
       const value = maxNode.flavors.get(name);
       if (value) {
-        return value.trim();
+        if (value instanceof String) {
+          return value.trim();
+        }
+        return value;
       }
     }
   };
 }
 
+function keywordsToArray(str) {
+  const keywords = str.toString().split(',');
+  return keywords.map(keyword => keyword.trim());
+}
+
 
 const titleRules = buildRuleset('title', [
   ['meta[property="og:title"]', node => node.element.content],
@@ -38,7 +46,7 @@ const canonicalUrlRules = buildRuleset('url', [
 ]);
 
 const keywordsRules = buildRuleset('keywords', [
-  ['meta[name="keywords"]', node => node.element.content],
+  ['meta[name="keywords"]', node => keywordsToArray(node.element.content)],
 ]);
 
 const iconRules = buildRuleset('icon', [

diff --git a/tests/metadataRules.test.js b/tests/metadataRules.test.js
@@ -18,7 +18,7 @@ function ruleTest(testName, testRule, expected, testTag) {
     const html = buildHTML(testTag);
     const doc = stringToDom(html);
     const found = testRule(doc);
-    assert.equal(found, expected, `Unable to find ${testName} in ${html}`);
+    assert.deepEqual(found, expected, `Unable to find ${testName} in ${html}`);
   });
 }
 
@@ -105,10 +105,10 @@ describe('Type Rule Tests', function() {
 
 
 describe('Keywords Rule Tests', function() {
-  const keywords = 'Cats, Kitties, Meow';
+  const keywords = ['Cats', 'Kitties', 'Meow'];
 
   const ruleTests = [
-    ['keywords', `<meta name="keywords" content="${keywords}" />`],
+    ['keywords', `<meta name="keywords" content="${keywords.join(', ')}" />`],
   ];
 
   ruleTests.map(([testName, testTag]) => ruleTest(testName, metadataRules.keywords, keywords, testTag));