Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

Extendable #31

Closed
wants to merge 3 commits into from
Closed

Extendable #31

wants to merge 3 commits into from

Conversation

k88hudson
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-16.7%) to 83.333% when pulling b9a967a on k88hudson:extendable into 82ac24e on mozilla:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-16.7%) to 83.333% when pulling 34cfd18 on k88hudson:extendable into 82ac24e on mozilla:master.

@arcturus
Copy link

\o/ +1000 to this PR! Things much more clear now.

The only thing I see is coming back to the old getMetadata function we lost the ability to create composite responses.

For example, before we were able to have a rule object like:

const rule1 = ...
const rule2 = ...
const rule3 = ...

const rules = {
  cat1: rule1,
  cat2: {
    att1: rule2,
    att2: rule3
  }  
};

That will give us a formatted response in the same way than the rules object.

If you decided that a plain object is better, we will need to remove the tests for this that right now are failing:
https://github.com/mozilla/page-metadata-parser/blob/master/tests/getMetadata.test.js#L39
https://github.com/mozilla/page-metadata-parser/blob/master/tests/getMetadata.test.js#L52

@jaredlockhart
Copy link
Collaborator

This will be covered by #50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants