Fix Twitter uses 'name' not 'property' attribute #66

pdehaan · 2016-09-15T22:23:43Z

Ref: #40

pdehaan · 2016-09-15T22:25:48Z

parser.js

@@ -73,6 +73,7 @@ const metadataRules = {
      ['meta[property="og:image:secure_url"]', node => node.element.getAttribute('content')],
      ['meta[property="og:image:url"]', node => node.element.getAttribute('content')],
      ['meta[property="og:image"]', node => node.element.getAttribute('content')],
+      ['meta[name="twitter:image"]', node => node.element.getAttribute('content')],


As discussed in #40, I added the syntactically correct meta[name="twitter:*"], but kept the existing meta[property="twitter:*"] as a fallback since it seems people are fallible and make mistakes/typos.

coveralls · 2016-09-15T22:26:07Z

Coverage remained the same at 100.0% when pulling c78a41a on pdehaan:issue-40 into 18c334a on mozilla:master.

pdehaan · 2016-09-15T22:26:22Z

r? @jaredkerim @wilsonpage

jaredlockhart · 2016-09-26T19:36:54Z

R+!

Fix Twitter uses 'name' not 'property' attribute

c78a41a

pdehaan commented Sep 15, 2016

View reviewed changes

pdehaan mentioned this pull request Sep 15, 2016

Fix twitter uses name not property attribute #40

Closed

jaredlockhart merged commit 93496b0 into mozilla:master Sep 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Twitter uses 'name' not 'property' attribute #66

Fix Twitter uses 'name' not 'property' attribute #66

pdehaan commented Sep 15, 2016

pdehaan Sep 15, 2016

coveralls commented Sep 15, 2016

pdehaan commented Sep 15, 2016

jaredlockhart commented Sep 26, 2016

Fix Twitter uses 'name' not 'property' attribute #66

Fix Twitter uses 'name' not 'property' attribute #66

Conversation

pdehaan commented Sep 15, 2016

pdehaan Sep 15, 2016

Choose a reason for hiding this comment

coveralls commented Sep 15, 2016

pdehaan commented Sep 15, 2016

jaredlockhart commented Sep 26, 2016