This repository has been archived by the owner on Feb 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredlockhart
force-pushed
the
90
branch
4 times, most recently
from
August 10, 2017 16:10
ed29877
to
0710139
Compare
k88hudson
approved these changes
Aug 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a suggestion but this seems good to me
url-utils.js
Outdated
@@ -0,0 +1,29 @@ | |||
if (global.DOMParser !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you want to check for global.URL
here?
url-utils.js
Outdated
@@ -0,0 +1,29 @@ | |||
if (global.DOMParser !== undefined) { | |||
// We're in Firefox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you've done does work, but because of the configuration you added to webpack you should actually be able to just do this for both:
const {URL} = require("url");
module.exports = {
makeUrlAbsolute(base, relative) {
return new URL(relative, base).href;
},
parseUrl(url) {
return new URL(url).host;
}
};
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.