Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

Remove Fathom 1.0 Dependency fixes #90 #94

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Remove Fathom 1.0 Dependency fixes #90 #94

merged 1 commit into from
Aug 10, 2017

Conversation

jaredlockhart
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 98.765% when pulling 0710139 on 90 into 2afb79a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 98.78% when pulling 0710139 on 90 into 2afb79a on master.

Copy link
Contributor

@k88hudson k88hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion but this seems good to me

url-utils.js Outdated
@@ -0,0 +1,29 @@
if (global.DOMParser !== undefined) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to check for global.URL here?

url-utils.js Outdated
@@ -0,0 +1,29 @@
if (global.DOMParser !== undefined) {
// We're in Firefox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you've done does work, but because of the configuration you added to webpack you should actually be able to just do this for both:

  const {URL} = require("url");
  module.exports = {
    makeUrlAbsolute(base, relative) {
      return new URL(relative, base).href;
    },
    parseUrl(url) {
      return new URL(url).host;
    }
};

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.837% when pulling e4b6911 on 90 into 2afb79a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.837% when pulling e4b6911 on 90 into 2afb79a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 98.78% when pulling cc4b84c on 90 into 2afb79a on master.

@jaredlockhart jaredlockhart merged commit 3274822 into master Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants