Skip to content
This repository has been archived by the owner on Jan 23, 2018. It is now read-only.

Split apart subscription actions #254

Closed
kumar303 opened this issue Jul 31, 2015 · 2 comments
Closed

Split apart subscription actions #254

kumar303 opened this issue Jul 31, 2015 · 2 comments
Labels
enhancement good first bug

Comments

@kumar303
Copy link
Contributor

Let's make two different subscription actions, subscribeWithCard and subscribeWithNewCard. This will make the code from #252 a little easier to read and maintain.
@kumar303 kumar303 self-assigned this Jul 31, 2015
@kumar303
Copy link
Contributor Author

The action tests should also be updated to check that all card fields are posted to the API

@kumar303 kumar303 mentioned this issue Jul 31, 2015
Merged
@kumar303 kumar303 removed their assignment Aug 7, 2015
@kumar303 kumar303 closed this as completed Sep 1, 2015
@kumar303
Copy link
Contributor Author

kumar303 commented Sep 1, 2015

better approach in #352 This adds explicit keyword args like creditCard and payMethodURI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumar303 @andymckay-limited-access