Skip to content

Commit

Permalink
Move gulp typestest to a separate GitHub Actions workflow
Browse files Browse the repository at this point in the history
This way we introduce more parallelism in the GitHub Actions tests, which should reduce overall runtime and thus cannot hurt.
It also means that we'd be able to (temporarily) land PRs with "broken" types, since this workflow won't be `Required`, such that TypeScript won't block general development.
  • Loading branch information
Snuffleupagus committed Nov 12, 2023
1 parent 26fcd26 commit 844e331
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 2 deletions.
34 changes: 34 additions & 0 deletions .github/workflows/types.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Types
on: [push, pull_request]
permissions:
contents: read

jobs:
test:
name: Test
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
node-version: [lts/*]

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Install Gulp
run: npm install -g gulp-cli

- name: Install other dependencies
run: npm install

- name: Run typestest
run: gulp typestest
3 changes: 1 addition & 2 deletions gulpfile.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2441,7 +2441,6 @@ gulp.task(
"ci-test",
gulp.series(
gulp.parallel("lint", "externaltest", "unittestcli"),
"lint-chromium",
"typestest"
"lint-chromium"
)
);

0 comments on commit 844e331

Please sign in to comment.