Merge pull request #6843 from timvandermeij/pr-6796-fixup

shading-pattern: Decreased `Shadings.SMALL_NUMBER`
mozilla · Jan 6, 2016 · 944d1e6 · 944d1e6
2 parents 3f19b3f + 90ec2c9
commit 944d1e6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/src/core/pattern.js b/src/core/pattern.js
@@ -102,10 +102,8 @@ var Pattern = (function PatternClosure() {
 var Shadings = {};
 
 // A small number to offset the first/last color stops so we can insert ones to
-// support extend.  Number.MIN_VALUE appears to be too small and breaks the
-// extend. 1e-7 works in FF but chrome seems to use an even smaller sized number
-// internally so we have to go bigger.
-Shadings.SMALL_NUMBER = 1e-2;
+// support extend. Number.MIN_VALUE is too small and breaks the extend.
+Shadings.SMALL_NUMBER = 1e-6;
 
 // Radial and axial shading have very similar implementations
 // If needed, the implementations can be broken into two classes

diff --git a/test/pdfs/.gitignore b/test/pdfs/.gitignore
@@ -197,6 +197,7 @@
 !issue6069.pdf
 !issue6106.pdf
 !issue6296.pdf
+!issue6298.pdf
 !bug1001080.pdf
 !issue6108.pdf
 !issue6113.pdf

diff --git a/test/pdfs/issue6298.pdf b/test/pdfs/issue6298.pdf
diff --git a/test/test_manifest.json b/test/test_manifest.json
@@ -2597,6 +2597,12 @@
        "rounds": 1,
        "type": "eq"
     },
+    {  "id": "issue6298.pdf",
+       "file": "pdfs/issue6298.pdf",
+       "md5": "214340be34f463611fc3127ad0695034",
+       "rounds": 1,
+       "type": "eq"
+    },
     {  "id": "issue5549.pdf",
        "file": "pdfs/issue5549.pdf",
        "md5": "6c36df6ebc583c9e18aad0ad00d257b8",