-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make linked test cases point to the Internet Archive #6854
Comments
|
It appears that we've now reached the point where every file, perhaps with one or two exceptions, that is possible to obtain through the Internet Archive have been fixed. Below is a summary of the ones that are left to fix, so we probably need to start looking into the possibility of replacing them with reduced test-cases, if at all possible. A number of these files are font related, which in theory should make it reasonable easy (albeit time-consuming) to create/verify reduced test-cases. (It might be simplest to see if Brendan manages to create the tool mentioned in #6650 (comment), before undertaking more work on that.)
|
We have quite a number of linked test cases in the https://github.com/mozilla/pdf.js/tree/master/test/pdfs folder. Some of them point to sources other than the Internet Archive or Bugzilla and might become unavailable, which is to be avoided.
It is better to fetch the files from the Internet Archive to be sure that they remain available. This should always be possible if the current source exists because once you input the link on the Internet Archive website it will archive the file automatically.
Below is a list of linked test cases that point to external sources and should be updated (obtained with
grep -L "bugzilla.mozilla.org\|archive.org" *.pdf.link
). Make sure that the hash of the Internet Archive file is the same as the hash in the test manifest.Additionally:
hmm.pdf
. The MD5 hash in the manifest matches the MD5 hash of the file from the link, but the bots complain about a mismatch.The text was updated successfully, but these errors were encountered: