Update the linked test case hmm.pdf to point to the intended version #6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case was changed in mozilla@1faca19 because the original file was not available anymore. However, its hash was also changed, meaning that we do not test the intended version anymore. This patch makes sure that we test the intented version by reverting to the original hash and using a link, also pointing to the Internet Archive, with the original file.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b85c9778b83c71b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3219dc3a972fb6b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3219dc3a972fb6b/output.txt Total script time: 20.87 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b85c9778b83c71b/output.txt Total script time: 21.32 mins
|
|
Looks good, thanks for fixing this! |
Snuffleupagus
added a commit
that referenced
this pull request
Jan 14, 2016
Update the linked test case hmm.pdf to point to the intended version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case was changed in 1faca19 because the original file was not available anymore. However, its hash was also changed, meaning that we do not test the intended version anymore.
This patch makes sure that we test the intented version by reverting to the original hash and using a link, also pointing to the Internet Archive, with the original file.
Note that this should resolve the MD5 mismatch warning in the test logs. The tests should still pass because we have always been testing the original file as it was never replaced on the servers after the above commit. This is a part of #6854.