Remove combineUrl from the test files

[timvandermeij]

Take a look at https://github.com/mozilla/pdf.js/search?utf8=%E2%9C%93&q=combineUrl for where it is still used. We should replace it with the URL constructor as done in https://github.com/mozilla/pdf.js/pull/7178/files.

[yurydelendik]

We still need to test the combineUrl function (e.g. keep it in util_spec) or remove that from our code.

[timvandermeij]

Good point. Now that I come to think of it, couldn't we remove it entirely since we have a polyfill for it (at

pdf.js/src/shared/util.js

Line 1692 in 68e8f5f

//// Polyfill from https://github.com/Polymer/URL

)?

[yurydelendik]

@brendandahl already wanted to remove that. Please notice that we shall properly handle if (!url) { case when it is needed.

[prakashpalanisamy]

Hi, This will be my first contribution, is it okay if I take this issue up and work on it?

[yurydelendik]

Hi, This will be my first contribution, is it okay

Sure, please read https://github.com/mozilla/pdf.js/wiki/Contributing

[prakashpalanisamy]

Thank you..

[prakashpalanisamy]

there is a source file having reference to combineUrl - api.js in display. Should I replace that refernece too? Or only the test file references?
If src refernces are to be replaced, Should the function also be removed from util.js? - assuming that it will not be used in the future.

[yurydelendik]

there is a source file having reference to combineUrl - api.js in display. Should I replace that refernece too?

Yes, you can replace that, remove tests and from util.js.