Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Dict.get with Dict.getArray at one spot in src/core/function.js #9734

Closed
Snuffleupagus opened this issue May 17, 2018 · 4 comments
Closed
Labels

Comments

@Snuffleupagus
Copy link
Collaborator

I was recently sorting through and throwing out old notes, when I found this and figured it wouldn't hurt to at least submit an issue.

Please refer to pull request #7295 for the background. Basically that PR missed one spot, so at

var size = toNumberArray(dict.get('Size'));

get should be replaced with getArray (which could help avoid future bugs).

Since this issue ought to be a good candidate for the 5-good-beginner-bug label, I'm including a link to https://github.com/mozilla/pdf.js/wiki/Contributing for good measure.

@ptmxyz
Copy link

ptmxyz commented May 18, 2018

On this. Will fix and submit a PR in a few minutes.

@Nacen
Copy link

Nacen commented May 26, 2018

Hello is this still open or should it be closed because a pr was already made

@arunikayadav42
Copy link

Can anybody help me get started please :) I would love to contribute.just a rookie in javascript

@timvandermeij
Copy link
Contributor

There is already a pull request for this issue above, but feel free to work on another open issue if that's not being worked on yet. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants