Use Dict.getArray, instead of Dict.get, when getting the 'Size' in constructSampled in src/core/function.js

[ptmxyz]

Use Dict.getArray, instead of Dict.get, when getting the 'Size' in constructSampled on line 189 of src/core/function.js

Fixes #9734.

[Snuffleupagus]

Drive by comment: Please provide a better commit message! Reading just the commit message, and not the code, it isn't really possible to understand the change. Furthermore the use of the word "last" isn't correct, since there's a number of Dict.get occurences in that file (but those should definitely not be changed).

A better suggestion might be e.g:

Use Dict.getArray, instead of Dict.get, when getting the 'Size' in constructSampled in src/core/function.js

[ptmxyz]

@Snuffleupagus thanks for the feedback! I updated my commit message and title accordingly.

[Snuffleupagus]

I updated my commit message and title accordingly.

It doesn't look like the commit message was updated, only the PR title; did you forget to force push your changes with git push -f ...?
Besides there's now a typo in the PR title, since there's no file called "functions.js" (note the extra "s"). Furthermore, it's still unnecessarily imprecise, so why not simply use the suggestion above verbatim!?

Since you'll need to actually push the changes anyway, please update the commit message to:
"Use Dict.getArray, instead of Dict.get, when getting the 'Size' in constructSampled in src/core/function.js (PR 7295 follow-up)"

[timvandermeij]

@pedrotp Hi, did you manage to update the commit message so we can try to merge it? You can do this locally with git commit --amend, entering the new commit message as outlined above and then using git push -f to push the new commit. Thank you!

[ptmxyz]

@timvandermeij @Snuffleupagus sorry, first commit. edited the commit message, description and title, should be good to go now. thanks again for the feedback.

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/21faef71b7d9230/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/1d59f23276c8253/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/21faef71b7d9230/output.txt

Total script time: 19.01 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.215.176.217:8877/1d59f23276c8253/output.txt

Total script time: 24.56 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/1d59f23276c8253/reftest-analyzer.html#web=eq.log

[timvandermeij]

Thank you for your contribution!

(Note that the failing tests on the Windows bot are known intermittent failures, so they are unrelated to this patch.)