Attempt to clean-up/restore pending rendering operations when errors occurs while a RenderTask runs (PR 10202 follow-up)
#10499
Conversation
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dfe4141b907b9ca/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e861cf8fcf7df8c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/dfe4141b907b9ca/output.txt Total script time: 2.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e861cf8fcf7df8c/output.txt Total script time: 5.10 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ffb69d540f3d20d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/0ad0c7fdce432a2/output.txt |
src/display/api.js
Outdated
| }); | ||
| } else { | ||
| Promise.resolve().then(this._nextBound).catch(this.callback); | ||
| Promise.resolve().then(this._nextBound).catch(this.cancel(this)); |
There was a problem hiding this comment.
D'oh, really stupid typo, fix incoming.
…occurs while a `RenderTask` runs (PR 10202 follow-up) This piggybacks of the existing `cancel` functionality, to ensure that any pending operations are closed *and* that any temporary canvases are actually being removed. Also simplifies `finishPaintTask` in `PDFPageView.draw` slightly, by converting it to an async function.
Snuffleupagus
force-pushed
the
renderTask-error-cleanup
branch
from
75b9cef
to
5081063
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ffb69d540f3d20d/output.txt Total script time: 17.77 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/0ad0c7fdce432a2/output.txt Total script time: 25.14 mins
Image differences available at: http://54.215.176.217:8877/0ad0c7fdce432a2/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ce71f8f21c132b3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ce71f8f21c132b3/output.txt Total script time: 1.68 mins Published |
|
Nice find! |
This piggybacks of the existing
cancelfunctionality, to ensure that any pending operations are closed and that any temporary canvases are actually being removed.Also simplifies
finishPaintTaskinPDFPageView.drawslightly, by converting it to an async function.