Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero the width/height of the temporary canvas used during JpegDecode (issue 10594) #10595

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Zero the width/height of the temporary canvas used during JpegDecode (issue 10594) #10595

merged 1 commit into from
Feb 28, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #10594.

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/5e501b4cc7ac823/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/515dd5fa8a5f0a2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/515dd5fa8a5f0a2/output.txt

Total script time: 17.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/5e501b4cc7ac823/output.txt

Total script time: 25.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/4978e2abb716c3b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/bcbb73be03bc914/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/bcbb73be03bc914/output.txt

Total script time: 18.14 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/4978e2abb716c3b/output.txt

Total script time: 25.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/4978e2abb716c3b/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 9559d57 into mozilla:master Feb 28, 2019
@timvandermeij
Copy link
Contributor

Really good!

@Snuffleupagus Snuffleupagus deleted the JpegDecode-zero-tmpCanvas branch March 1, 2019 03:17
@Snuffleupagus Snuffleupagus mentioned this pull request Apr 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snuffleupagus @pdfjsbot @timvandermeij