Add type validation to the default_preferences generation (PR 10548 follow-up)
#10610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… follow-up) The generated `default_preferences.json` file is necessary when initializing the Firefox preferences, which only supports certain types, hence this patch adds additional validation to help prevent run-time errors in Firefox. Given that these changes add a code-path to `AppOptions.getAll` which could throw, the `OptionKind.PREFERENCE` branch is also modified to require *exact* matching to prevent (future) errors in the viewer. Finally the conditionally defined `defaultOptions` will no longer (potentially) be considered during the `gulp default_preferences` task, to make it more difficult for them to be accidentally included.
|
/botio-windows lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4a4b35b8e27ccc5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/0fc8f9f6a92f752/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4a4b35b8e27ccc5/output.txt Total script time: 1.80 mins Published |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/0fc8f9f6a92f752/output.txt Total script time: 2.85 mins
|
timvandermeij
approved these changes
Mar 6, 2019
|
Thank you for making this less prone to errors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated
default_preferences.jsonfile is necessary when initializing the Firefox preferences, which only supports certain types, hence this patch adds additional validation to help prevent run-time errors in Firefox.Given that these changes add a code-path to
AppOptions.getAllwhich could throw, theOptionKind.PREFERENCEbranch is also modified to require exact matching to prevent (future) errors in the viewer.Finally the conditionally defined
defaultOptionswill no longer (potentially) be considered during thegulp default_preferencestask, to make it more difficult for them to be accidentally included.