Remove the Firefox-specific 'read with streaming' unit-test #10668
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5db9aba65358dbe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/48270e71d5b43c9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5db9aba65358dbe/output.txt Total script time: 2.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/48270e71d5b43c9/output.txt Total script time: 5.33 mins
|
Support for the non-standard `moz-chunked-arraybuffer` response type is in the process of being removed from Firefox; see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1411865 For the time being, you probably want to keep support for this in the general PDF.js library given that feature detection is used. However, removing the unit-test immediately seems reasonable, since it will otherwise start failing once the platform support for `moz-chunked-arraybuffer` is gone. Fixes 8851; please note that if unit-tests for the code in `fetch_stream.js` are wanted, which I'm assuming they are, those should live in their own file rather than being lumped into `network_spec.js` anyway.
Snuffleupagus
force-pushed
the
rm-read_with_streaming-test
branch
from
b6e5ef7
to
234c1d2
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/12a71de75009098/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/60e034a12bf2d2a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/12a71de75009098/output.txt Total script time: 2.71 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/60e034a12bf2d2a/output.txt Total script time: 5.30 mins
|
Support for the non-standard
moz-chunked-arraybufferresponse type is in the process of being removed from Firefox; see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1411865For the time being, you probably want to keep support for this in the general PDF.js library given that feature detection is used. However, removing the unit-test immediately seems reasonable, since it will otherwise start failing once the platform support for
moz-chunked-arraybufferis gone.Fixes #8851; please note that if unit-tests for the code in
fetch_stream.jsare wanted, which I'm assuming they are, those should live in their own file rather than being lumped intonetwork_spec.jsanyway.