Remove moz-chunked-arraybuffer support, and related code, from src/display/network.js
#10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
rm-moz-chunked-arraybuffer
branch
from
a4ef87c
to
0f76e6f
Compare
Snuffleupagus
force-pushed
the
rm-moz-chunked-arraybuffer
branch
3 times, most recently
from
abf85c8
to
7af3683
Compare
…/display/network.js` The `moz-chunked-arraybuffer` responseType is a non-standard property, which has been subsumed by the Fetch API, and it's in the process of being removed from Firefox; please see https://bugzilla.mozilla.org/show_bug.cgi?id=1120171 and https://bugzilla.mozilla.org/show_bug.cgi?id=1411865 *Please note:* Rather than waiting for both `Fetch` *and* `ReadableStream` to be available in e.g. a Firefox ESR version (which is probably going to be 68 at the earliest), let's just decide that PDF.js release `2.1.266` will be the last one with `moz-chunked-arraybuffer` support and land this patch (since nothing should outright break without it anyway).
Snuffleupagus
changed the title
moz-chunked-arraybuffer support, and related code, from src/display/network.jsmoz-chunked-arraybuffer support, and related code, from src/display/network.js
Snuffleupagus
force-pushed
the
rm-moz-chunked-arraybuffer
branch
from
7af3683
to
b40e672
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/366274d15fad96d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9b791948b42985c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/366274d15fad96d/output.txt Total script time: 18.20 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9b791948b42985c/output.txt Total script time: 25.78 mins
|
Both of these have now landed, hence I believe that we should just move forward with this PR. |
timvandermeij
approved these changes
Apr 5, 2019
|
Very nice cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
moz-chunked-arraybufferresponseType is a non-standard property, which has been subsumed by the Fetch API, and it's in the process of being removed from Firefox; please see https://bugzilla.mozilla.org/show_bug.cgi?id=1120171 and https://bugzilla.mozilla.org/show_bug.cgi?id=1411865Please note: Rather than waiting for both
FetchandReadableStreamto be available in e.g. a Firefox ESR version (which is probably going to be 68 at the earliest), let's just decide that PDF.js release2.1.266will be the last one withmoz-chunked-arraybuffersupport and land this patch (since nothing should outright break without it anyway).