[Firefox] Avoid displaying the indeterminate loadingBar when disableStream=true is set (PR 10714 follow-up)
#10742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Stream=true` is set (PR 10714 follow-up) While PR 10714 did address the `disableRange=true` case, it also managed to "break" the `disableStream=true` case instead since the indeterminate loadingBar is now displayed when it shouldn't; sorry about that! The solution is simple enough though, don't attempt to fallback to `_fullRequestReader.onProgress` when handling "incomplete" loading information.
Snuffleupagus
force-pushed
the
firefox-transport-disableStream-progress
branch
from
bf04f18
to
5e9b606
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fd747d4faccacad/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/0cc8bf2274066de/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/fd747d4faccacad/output.txt Total script time: 2.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/0cc8bf2274066de/output.txt Total script time: 5.76 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/271b7dbe85d2260/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/271b7dbe85d2260/output.txt Total script time: 1.88 mins Published |
timvandermeij
approved these changes
Apr 16, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While PR #10714 did address the
disableRange=truecase, it also managed to "break" thedisableStream=truecase instead since the indeterminate loadingBar is now displayed when it shouldn't; sorry about that!The solution is simple enough though, don't attempt to fallback to
_fullRequestReader.onProgresswhen handling "incomplete" loading information. Edit: Smaller diff with https://github.com/mozilla/pdf.js/pull/10742/files?w=1/cc @timvandermeij