[api-minor] Implement contents and creation date for the correct annotation types #10833
Conversation
The specification states that `Contents` can be available for every annotation types instead of only for markup annotations.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7e1f7d1fabc7f2c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/14fdbf83b3373d5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/7e1f7d1fabc7f2c/output.txt Total script time: 17.80 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/14fdbf83b3373d5/output.txt Total script time: 25.71 mins
|
|
@Snuffleupagus Do you perhaps have time to review this? |
The specification states that `CreationDate` is only available for markup annotations instead of for all annotation types. Moreover, popup annotations are not markup annotations according to the specification, so the creation date inheritance from the parent annotation is also removed there (note that only the modification date is used in e.g., the viewer).
timvandermeij
force-pushed
the
annotation-fixes
branch
from
95ace1f
to
bc1eb49
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/55bb54461065da4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/5c562eb702a9167/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/55bb54461065da4/output.txt Total script time: 17.81 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5c562eb702a9167/output.txt Total script time: 25.71 mins
|
The commit messages contain more information about the individual changes.
Thanks to @vlastimilmaca for finding this! This patch cleans this up so it doesn't have to be done in the scope of the IRT/RT patch.