Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Annotations with too large border widths, to prevent the annotationLayer from rendering it over the surrounding document (bug 1552113) #10877

Merged
merged 1 commit into from
Jun 2, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented May 31, 2019

The border width will instead fallback to the default value of 1, rather than ignoring it altoghether, to also ensure that e.g. LinkAnnotations become clickable as intended.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1552113

src/core/annotation.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jun 1, 2019

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/acef21b0cc250cd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 1, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/acef21b0cc250cd/output.txt

Total script time: 1.85 mins

Published

@Snuffleupagus Snuffleupagus force-pushed the bug-1552113 branch 2 times, most recently from 1645f47 to 73139de Compare June 1, 2019 13:50
…notationLayer` from rendering it over the surrounding document (bug 1552113)

The border `width` will instead fallback to the default value of `1`, rather than ignoring it altoghether, to also ensure that e.g. `LinkAnnotation`s become clickable as intended.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1552113
@Snuffleupagus Snuffleupagus changed the title [WIP] Truncate ridiculously large Annotation widths to the Rect entry, to prevent the annotationLayer from rendering it over the surrounding document (bug 1552113) Ignore Annotations with too large border widths, to prevent the annotationLayer from rendering it over the surrounding document (bug 1552113) Jun 1, 2019
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 1, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/766e0811943a2d2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 1, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5f2b3ebcd162c77/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 1, 2019

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/5f2b3ebcd162c77/output.txt

Total script time: 17.83 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 1, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/766e0811943a2d2/output.txt

Total script time: 25.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2019

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/cef1f94aabfbbb3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/cef1f94aabfbbb3/output.txt

Total script time: 1.95 mins

Published

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2019

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/42638a30cd22e77/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2019

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7da2a7081ecc3b5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/7da2a7081ecc3b5/output.txt

Total script time: 16.26 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/42638a30cd22e77/output.txt

Total script time: 23.30 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit 63014eb into mozilla:master Jun 2, 2019
@timvandermeij
Copy link
Contributor

Thank you for fixing this special case!

@Snuffleupagus Snuffleupagus deleted the bug-1552113 branch June 2, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants