Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the version of eslint-plugin-mozilla to prevent failures on Travis (issue 10901) #10905

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jun 15, 2019

It appears that the changes in eslint-plugin-mozilla version 1.3.0, see https://bugzilla.mozilla.org/show_bug.cgi?id=1556013, causes dependency issues on Travis.

Fixes #10901 (this at least fixes Travis for now, and figuring out why PR #10904 didn't work can be done once the package actually needs updating).

…vis (issue 10901)

It appears that the changes in `eslint-plugin-mozilla` version `1.3.0`, see https://bugzilla.mozilla.org/show_bug.cgi?id=1556013, causes dependency issues on Travis.
@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/fb710c0f099f118/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/db53ee806542be8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/fb710c0f099f118/output.txt

Total script time: 0.97 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/db53ee806542be8/output.txt

Total script time: 2.90 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit 0471a99 into mozilla:master Jun 15, 2019
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the pin-eslint-plugin-mozilla branch June 15, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis CI build fails
3 participants