Make the find helper function, in src/core/document.js, more efficient by using peekBytes rather reading the stream one byte at a time
#10947
Conversation
…cient by using `peekBytes` rather reading the stream one byte at a time *Please note:* A a similar change was attempted in PR 5005, but it was subsequently backed out in PR 5069. Unfortunately I don't think anyone ever tried to debug *exactly* why it didn't work, since it ought to have worked, and having re-tested this now I'm not able to reproduce the problem any more. However, given just how inefficient the current code is, with thousands of strictly unnecessary function calls for each `find` invocation, I'd really like to try fixing this again.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c5b8642127876c6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/bf0551b6c53f8ff/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c5b8642127876c6/output.txt Total script time: 17.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/bf0551b6c53f8ff/output.txt Total script time: 25.96 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/51aed89a4df7d80/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/51aed89a4df7d80/output.txt Total script time: 1.80 mins Published |
|
Thank you! I agree that this should really work, and looking at how |
Please note: A a similar change was attempted in PR #5005, but it was subsequently backed out in PR #5069.
Unfortunately I don't think anyone ever tried to debug exactly why it didn't work, since it ought to have worked, and having re-tested this now I'm not able to reproduce the problem any more. However, given just how inefficient the current code is, with thousands of strictly unnecessary function calls for each
findinvocation, I'd really like to try fixing this again.