Commits on Sep 1, 2019

1. Remove support for the scope parameter in the MessageHandler.on m… …

   …ethod
   
   At this point in time it's easy to convert the `MessageHandler.on` call-sites to use arrow functions, and thus let the JavaScript engine handle scopes for us, rather than having to manually keep references to the relevant scopes in `MessageHandler`.[1]
   An additional benefit of this is that a couple of `Function.prototype.call()` instances can now be converted into "normal" function calls, which should be a tiny bit more efficient.
   
   All in all, I don't see any compelling reason why it'd be necessary to keep supporting custom `scope`s in the `MessageHandler` implementation.
   
   ---
   [1] In the event that a custom scope is ever needed, simply using `bind` on the handler function when calling `MessageHandler.on` ought to work as well.

   

   Snuffleupagus committed Sep 1, 2019
   Copy the full SHA

   055f039 View commit details

   Browse the repository at this point in the history